Increase test_failed_job_status timeout in test_job_submission
#22643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekris-anyscale
requested review from
wuisawesome,
ijrsvt,
joeybai,
alanwguo and
architkulkarni
as code owners
shrekris-anyscale
changed the title
wait_for_condition timeouttest_failed_job_status timeout in test_job_submission
edoakes
approved these changes
Feb 24, 2022
wuisawesome
approved these changes
Feb 25, 2022
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
…ay-project#22643) `test_job_submission` has become [flakey](https://flakey-tests.ray.io/) due to timeout. This change increases the timeout in `test_failed_job_status` from 10 to 25 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
test_job_submissionhas become flakey due to timeout. This change increases the timeout intest_failed_job_statusfrom 10 to 25 seconds.Related issue number
N/A
Checks
scripts/format.shto lint the changes in this PR.