Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime env] Make plugin setup process that has not been refactor run in threads. #22588

Merged
merged 6 commits into from
Feb 28, 2022
Merged

[runtime env] Make plugin setup process that has not been refactor run in threads. #22588

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
15fd28b
fix await
Catch-Bull Feb 23, 2022
9bde9e7
add UT
Catch-Bull Feb 23, 2022
8d96ad5
add annotations and TODO
Catch-Bull Feb 24, 2022
1b409f1
add print in test
Catch-Bull Feb 25, 2022
37698a6
fix UT
Catch-Bull Feb 25, 2022
da35142
fix lint
Catch-Bull Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix UT
  • Loading branch information
@Catch-Bull
Catch-Bull committed Feb 25, 2022
commit 37698a603287a0d110fa9c7443a3da2ca294c1c2
3 changes: 2 additions & 1 deletion python/ray/tests/test_runtime_env_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,10 @@ def modify_context(


def test_plugin_hang(ray_start_regular):
env_key = MyPluginForHang.env_key
@ray.remote(num_cpus=0.1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before this PR, this case will be failed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding this!

def f():
return os.environ[MyPluginForHang.env_key]
return os.environ[env_key]

refs = [
f.options(
Expand Down