Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Make Deployment handle serializable #22473

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

Fixes an unpicklable lambda error that prevented handles from being passed into Serve deployment constructors. The idea for the fix is from @simon-mo.

Related issue number

Closes #22110

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo merged commit df85d31 into ray-project:master Feb 18, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant pickle RayServeSyncHandle from Ray1.9
2 participants