Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFrame] Implement __array_wrap__ #2218

Merged
merged 2 commits into from
Jun 11, 2018
Merged

[DataFrame] Implement __array_wrap__ #2218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
724dc4a
Implement __array_wrap__
devin-petersohn Jun 8, 2018
090f4a4
Removing unnecessary test
devin-petersohn Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python/ray/dataframe/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4917,9 +4917,8 @@ def __array__(self, dtype=None):
return to_pandas(self).__array__(dtype=dtype)

def __array_wrap__(self, result, context=None):
raise NotImplementedError(
"To contribute to Pandas on Ray, please visit "
"github.com/ray-project/ray.")
# TODO: This is very inefficient, see also __array__ and as_matrix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a warning here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it would be good to add a warning. It would warning every time users run np.power or whatever. I am adding it to the documentation page, so hopefully that would be enough.

return to_pandas(self).__array_wrap__(result, context=context)

def __getstate__(self):
raise NotImplementedError(
Expand Down