Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAMLs] Fix comments about autoscaler round-robining #22002

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Jan 31, 2022

Why are these changes needed?

Fixes comments that refer to implementation behavior (spreading nodes across AZs) from prior to #19051

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt ijrsvt changed the title [YAMLs] Fix Comments to Reflect that we do not round-robin Nodes anymore [YAMLs] Fix comments about autoscaler round-robining Jan 31, 2022
@ijrsvt ijrsvt merged commit c9a4b17 into ray-project:master Feb 17, 2022
@ijrsvt ijrsvt deleted the fix-round-robin-docs-in-yamls branch February 17, 2022 21:59
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants