Added functionality for retrieving variables from control dependencies #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Tests if all variables are properly retrieved, 2 variables and 2 momentum | ||
| # variables. | ||
| self.assertEqual(len(net_vars.variables.items()), 4) | ||
|
|
There was a problem hiding this comment.
Can you also call get_weights and set_weights and make sure those methods work in this case? (you'll probably need to call init as well).
| if op.node_def.op == "Variable": | ||
| variable_names.append(op.node_def.name) | ||
| tf_obj = queue.popleft() | ||
| if hasattr(tf_obj, "op"): |
There was a problem hiding this comment.
This if statement is a bit confusing to me, why are we doing this?
There was a problem hiding this comment.
If it's the right thing to do, could you document why?
|
We also need to change |
pcmoritz
reviewed
Jan 29, 2017
| prefix = str(uuid.uuid1().hex) | ||
| # Use the tensorflow variable_scope to prefix all of the variables | ||
| with tf.variable_scope(prefix): | ||
| # Use a seperate graph for each network. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is primarily for passing in
opt.minimizeas the loss function toTensorFlowVariables, and now no longer has the prefixing.