[DataFrame] Fix equals and make it more efficient #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
pschafhalter
suggested changes
Jun 4, 2018
python/ray/dataframe/dataframe.py
Outdated
|
|
||
| @ray.remote | ||
| def _equals_helper(left, right): | ||
| right = pd.concat(ray.get(right.tolist()), axis=1) |
There was a problem hiding this comment.
Make sure to pass copy=False.
pschafhalter
approved these changes
Jun 4, 2018
|
Test PASSed. |
|
Merged. Thanks @devin-petersohn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous equals had a bug and created a remote task for each line. New implementation uses
_copartitionto efficiently align both dataframes.Also added some documentation for
_match_partitioningbecause when I tried to use it, it caused problems forDataFramesthat haddropon one axis and an operation on the opposite axis (i.e. adf.drop(columns=['A', 'B']).drop(index=[1, 4]).