Fix bug in tensorflow tests. #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
reviewed
Jan 20, 2017
| ray.env.net2[0].set_weights(weights) | ||
|
|
||
| # Get the weights. | ||
| def swap_weights(weights1, weights2): |
There was a problem hiding this comment.
Can you get rid of this and replace the call below with set_and_get_weights?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were causing problems because depending on how tasks got scheduled, we might be calling
get_weightswithout ever having calledset_weightsso the weights were uninitialized.This was because we were breaking the abstraction that workers are stateless..