Add tip for formatting files with yapf #2158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
ericl
reviewed
May 30, 2018
| 5. **Autoformatting code**. We use ``yapf`` | ||
| https://github.com/google/yapf for linting, and the config file is | ||
| located at ``.style.yapf``. We recommend adding ``.travis/yapf.sh`` | ||
| to git's ``pre-push`` hook, so that you never have to worry about |
There was a problem hiding this comment.
This is too slow to run on each push. How do you execute yapf against a subset of files, or only changed files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Tells devs how to use yapf easily.
Related issue number
#2149 Addresses @ericl request.