Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Unskipped tests in test_constructor_failure.py & test_ray_client.py #21423

Merged
merged 2 commits into from
Jan 7, 2022
Merged

[serve] Unskipped tests in test_constructor_failure.py & test_ray_client.py #21423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2698dc
Unskipped tests in serve: test_constructor_failure.py
czgdp1807 Jan 7, 2022
d27f49e
Unskipped tests in serve: test_ray_client.py
czgdp1807 Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions python/ray/serve/tests/test_constructor_failure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from ray import serve


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_deploy_with_consistent_constructor_failure(serve_instance):
# # Test failed to deploy with total of 1 replica
@serve.deployment(num_replicas=1)
Expand Down Expand Up @@ -47,7 +46,6 @@ async def serve(self, request):
assert deployment_dict["ConstructorFailureDeploymentTwoReplicas"] == []


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_deploy_with_partial_constructor_failure(serve_instance):
# Test deploy with 2 replicas but one of them failed all
# attempts
Expand Down Expand Up @@ -85,7 +83,6 @@ async def serve(self, request):
assert len(deployment_dict["PartialConstructorFailureDeployment"]) == 2


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_deploy_with_transient_constructor_failure(serve_instance):
# Test failed to deploy with total of 2 replicas,
# but first constructor call fails.
Expand Down
7 changes: 3 additions & 4 deletions python/ray/serve/tests/test_ray_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ def serve_with_client(ray_client_instance, ray_init_kwargs=None):
ray.util.disconnect()


@pytest.mark.skipif(sys.platform != "linux", reason="Buggy on MacOS + Windows")
@pytest.mark.skipif(
sys.platform != "linux" and sys.platform != "win32",
reason="Buggy on MacOS")
def test_ray_client(ray_client_instance):
ray.util.connect(ray_client_instance, namespace="default_test_namespace")

Expand Down Expand Up @@ -115,7 +117,6 @@ class A:
ray.util.disconnect()


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows")
def test_quickstart_class(serve_with_client):
serve.start()

Expand All @@ -131,7 +132,6 @@ def hello(request):
assert response == "Hello serve!"


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows")
def test_quickstart_counter(serve_with_client):
serve.start()

Expand All @@ -155,7 +155,6 @@ def __call__(self, *args):
print("query 2 finished")


@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows")
@pytest.mark.parametrize(
"serve_with_client", [{
"runtime_env": {
Expand Down