Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Placement Group] Make placement group prepare resource rpc request batched #20897

Merged
merged 44 commits into from
Dec 16, 2021

Conversation

clay4megtr
Copy link
Contributor

@clay4megtr clay4megtr commented Dec 6, 2021

Why are these changes needed?

This is one part of this refactor, #20715 , make the prepare resource RPC requests batched per node.

Related issue number

#20715

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also handle the windows build failure? (I guess there's the compilation error). I will start reviewing once pg tests are passing!

src/ray/raylet/node_manager.cc Outdated Show resolved Hide resolved
@clay4megtr
Copy link
Contributor Author

@rkooo567 all pg tests have passed.

Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have some questions regarding simplification!

src/ray/gcs/gcs_server/gcs_placement_group_scheduler.cc Outdated Show resolved Hide resolved
src/ray/common/bundle_spec.h Outdated Show resolved Hide resolved
src/ray/common/bundle_spec.cc Outdated Show resolved Hide resolved
src/ray/gcs/gcs_server/gcs_placement_group_scheduler.h Outdated Show resolved Hide resolved
src/ray/gcs/test/gcs_test_util.h Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.cc Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.h Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.cc Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.cc Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.cc Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.cc Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.cc Outdated Show resolved Hide resolved
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 8, 2021
@clay4megtr clay4megtr removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 12, 2021
@clay4megtr clay4megtr requested a review from rkooo567 December 12, 2021 14:56
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is close to merge! Btw, please don't resolve the comment without addressing it! Can you instead comment why you don't address them?

src/ray/gcs/gcs_server/gcs_placement_group_scheduler.cc Outdated Show resolved Hide resolved
src/ray/gcs/gcs_server/gcs_placement_group_scheduler.cc Outdated Show resolved Hide resolved
src/ray/gcs/test/gcs_test_util.h Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.h Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.h Outdated Show resolved Hide resolved
src/ray/raylet/placement_group_resource_manager.h Outdated Show resolved Hide resolved
src/ray/raylet_client/raylet_client.cc Show resolved Hide resolved
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 13, 2021
@clay4megtr clay4megtr removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 15, 2021
@clay4megtr clay4megtr requested a review from rkooo567 December 15, 2021 11:56
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Thanks for handling all comments again :)!!

@rkooo567
Copy link
Contributor

Test failure seems unrelated.

@rkooo567 rkooo567 merged commit 1edf4ab into ray-project:master Dec 16, 2021
@rkooo567
Copy link
Contributor

Time to do the same thing for commit/removal! haha

rkooo567 added a commit to rkooo567/ray that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants