-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Placement Group] Make placement group prepare resource rpc request batched #20897
[Placement Group] Make placement group prepare resource rpc request batched #20897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also handle the windows build failure? (I guess there's the compilation error). I will start reviewing once pg tests are passing!
@rkooo567 all pg tests have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have some questions regarding simplification!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is close to merge! Btw, please don't resolve the comment without addressing it! Can you instead comment why you don't address them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Thanks for handling all comments again :)!!
Test failure seems unrelated. |
Time to do the same thing for commit/removal! haha |
…equest batched (ray-project#20897)" This reverts commit 1edf4ab.
Why are these changes needed?
This is one part of this refactor, #20715 , make the prepare resource RPC requests batched per node.
Related issue number
#20715
Checks
scripts/format.sh
to lint the changes in this PR.