[DataFrame] Fixes dropna subset bug #2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalgosar
changed the title
|
Test FAILed. |
|
Test PASSed. |
python/ray/dataframe/dataframe.py
Outdated
| if how is not None and how not in ['any', 'all']: | ||
| raise ValueError('invalid how option: %s' % how) | ||
| if how is None and thresh is None: | ||
| raise TypeError('must specify how or thresh') | ||
|
|
||
| if subset is not None: | ||
| subset = set(subset) | ||
| axis = pd.DataFrame()._get_axis_number(axis) |
There was a problem hiding this comment.
This needs to get moved back:
In [3]: df2.dropna(axis=12, how='whatever')
ValueError: No axis named 12 for object type <class 'pandas.core.frame.DataFrame'>
|
Test PASSed. |
devin-petersohn
approved these changes
May 10, 2018
alok
added a commit
to alok/ray
that referenced
this pull request
May 11, 2018
* master: [xray] Fix UniqueID hashing for object and task IDs. (ray-project#2017) [DataFrame] Fixing bugs in groupby (ray-project#2031) [DataFrame] Fixes dropna subset bug (ray-project#2018)
alok
added a commit
to alok/ray
that referenced
this pull request
May 11, 2018
* master: [xray] Fix UniqueID hashing for object and task IDs. (ray-project#2017) [DataFrame] Fixing bugs in groupby (ray-project#2031) [DataFrame] Fixes dropna subset bug (ray-project#2018) [DataFrame] Implement where (ray-project#1989)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where
subsetwas not used correctly when passed intodf.dropna.