Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] /api/snapshot works with all Serve KVStores #19772

Merged
merged 2 commits into from
Oct 27, 2021
Merged

[Serve] /api/snapshot works with all Serve KVStores #19772

merged 2 commits into from
Oct 27, 2021

Conversation

simon-mo
Copy link
Contributor

Why are these changes needed?

Make sure that the snapshot is written to the internal kv regardless of checkpoint location.

Related issue number

Closes #19752

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo merged commit 6afbd1f into ray-project:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

@jiaodong jiaodong Awaiting requested review from jiaodong

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

Assignees

@edoakes edoakes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Serve] Snapshot are put to Serve KV Store, not RayInternalKVStore
2 participants
@simon-mo @edoakes