Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Deflake test metrics #19711

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Oct 25, 2021

Closes #19715

Verified no longer flaky by running it in build box environment. The dashboard takes more than 2s to startup. But the test wait_until_succeeded_without_exception timeout after 1s.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Closes ray-project#19649

Verified no longer flaky by running it in build box environment.
Copy link
Member

@jiaodong jiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix ! Do we know what contributed to the potential increase of dashboard starting time ? I think my PR is simply deleting existing unused job server and in its async run() it will create an JobManager instance.

Maybe calling ray.remote() on constructor ?

https://sourcegraph.com/github.com/ray-project/ray/-/blob/python/ray/_private/job_manager/job_manager.py?L166:14

@simon-mo
Copy link
Contributor Author

Probably yeah.

@simon-mo simon-mo merged commit 5330aab into ray-project:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_metrics is flaky
3 participants