Use automatic memory management in Redis modules. #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
LGTM. It might be good to keep in mind this could have some performance impact (see the |
concretevitamin
approved these changes
Apr 3, 2018
|
Before merging let’s try this and monitor for memory leaks.
…On Tue, Apr 3, 2018 at 10:53 AM Zongheng Yang ***@***.***> wrote:
LGTM. It might be good to keep in mind this could have some performance
impact (see the autoMemory*() functions in redis module.c).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1797 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAPOrZJT5n1JGVR_odqPY3N3Z6siN2--ks5tk7cmgaJpZM4S-K8U>
.
|
|
Test PASSed. |
This was referenced May 22, 2018
Closed
alok
added a commit
to alok/ray
that referenced
this pull request
May 24, 2018
* master: [DataFrame] Refactor GroupBy Methods and Implement Reindex (ray-project#2101) Initial Support for Airspeed Velocity (ray-project#2113) Use automatic memory management in Redis modules. (ray-project#1797) [DataFrame] Test bugfixes (ray-project#2111) [DataFrame] Update initializations of IndexMetadata which use outdated APIs (ray-project#2103)
alok
added a commit
to alok/ray
that referenced
this pull request
May 25, 2018
* master: Prototype named actors. (ray-project#2129) Update arrow to latest master (ray-project#2100) [DataFrame] Speed up dtypes (ray-project#2118) do not fetch from dead Plasma Manager (ray-project#2116) [DataFrame] Refactor GroupBy Methods and Implement Reindex (ray-project#2101) Initial Support for Airspeed Velocity (ray-project#2113) Use automatic memory management in Redis modules. (ray-project#1797) [DataFrame] Test bugfixes (ray-project#2111) [DataFrame] Update initializations of IndexMetadata which use outdated APIs (ray-project#2103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1795
This also fixes the memory leak in #2119.