Update documentation and autoscaler to find 0.4.0. #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
richardliaw
approved these changes
Mar 28, 2018
|
retest this please |
|
Test FAILed. |
|
@robertnishihara maybe this needs to be rebased off master..? |
|
Why? There's no conflict as far as I can tell. |
|
oh just for the sake of getting jenkins tests to pass, although there is no
conflict
…On Thu, Mar 29, 2018 at 4:39 PM Robert Nishihara ***@***.***> wrote:
Why? There's no conflict as far as I can tell.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1789 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEUc5aAqi4-zT6tYwvyupgl4ipnt7CULks5tjXDEgaJpZM4S8UE0>
.
|
|
should we merge this (despite all tests failing)? |
|
I'll rebase. |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we'll have to actually upload wheels before this works.