-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the setuptools_scm issue #1784
Conversation
Test FAILed. |
Test PASSed. |
Test FAILed. |
The current fix doesn't seem to work. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
Test FAILed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
python/build-wheel-macos.sh
Outdated
@@ -48,9 +48,11 @@ for ((i=0; i<${#PY_VERSIONS[@]}; ++i)); do | |||
PIP_CMD="$(dirname $PYTHON_EXE)/pip$PY_MM" | |||
|
|||
pushd python | |||
# Upgrade pip. | |||
PATH=$MACPYTHON_PY_PREFIX/$PY_MM/bin:$PATH $PYTHON_EXE -m pip install --upgrade pip setuptools wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't change the PATH, just use $PIP_CMD
python/build-wheel-macos.sh
Outdated
@@ -48,9 +48,11 @@ for ((i=0; i<${#PY_VERSIONS[@]}; ++i)); do | |||
PIP_CMD="$(dirname $PYTHON_EXE)/pip$PY_MM" | |||
|
|||
pushd python | |||
# Upgrade pip. | |||
PATH=$MACPYTHON_PY_PREFIX/$PY_MM/bin:$PATH $PYTHON_EXE -m pip install --upgrade pip setuptools wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, are you sure it's necessary to upgrade all of those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try just pip
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
#1782