Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Dreamer fixes and reinstate Dreamer test. #17821

Merged
merged 10 commits into from
Aug 18, 2021
Merged

[RLlib] Dreamer fixes and reinstate Dreamer test. #17821

merged 10 commits into from
Aug 18, 2021

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Aug 13, 2021 •
edited by sven1977
Loading

Dreamer is currently broken and the simple compilation test case has been uncommented.
This PR:

  • Fixes the some issues when running Dreamer.
  • Reinstates the compilation test using a simple RandomEnv with an image observation space.

NOTE: More testing and benchmarking is required to get the Dreamer algo to a confidence level of the other RLlib algorithms.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 changed the title [wip/rllib] Rllib dreamer fix [RLlib] Dreamer fixes and reinstate Dreamer test. Aug 18, 2021
@sven1977 sven1977 marked this pull request as ready for review August 18, 2021 13:20
sven1977
sven1977 approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for the initiative @krfricke ! :)

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 18, 2021
@sven1977 sven1977 merged commit bf3eaa9 into ray-project:master Aug 18, 2021
@krfricke krfricke mentioned this pull request Sep 23, 2021
Closed
2 tasks
@krfricke krfricke deleted the rllib-dreamer-fix branch September 22, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

Assignees

@sven1977 sven1977

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krfricke @sven1977