Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] Better exceptions with traceback in TorchPolicy #17690

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

juliusfrost
Copy link
Member

@juliusfrost juliusfrost commented Aug 10, 2021

Why are these changes needed?

Previously exceptions were not showing the full traceback when using a gpu. This fixes TorchPolicy to ouput the cause of the error using the raise ... from statement.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@juliusfrost juliusfrost requested a review from sven1977 August 10, 2021 00:39
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome enhancement! Thanks @juliusfrost .

@sven1977 sven1977 merged commit 6891dee into ray-project:master Aug 11, 2021
@juliusfrost juliusfrost deleted the better-multi-gpu-errors branch August 25, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants