Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong invariant pubsub #17620

Merged
merged 4 commits into from
Aug 6, 2021

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Aug 5, 2021

Why are these changes needed?

There was a simple logic mistake.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
Copy link
Contributor Author

rkooo567 commented Aug 6, 2021

Failing tests were flaky in the master

@rkooo567 rkooo567 merged commit 4616e8a into ray-project:master Aug 6, 2021
krfricke pushed a commit to krfricke/ray that referenced this pull request Aug 9, 2021
* ip

* loose check failure

* Fix the bug properly.

* Fix comments.

(cherry picked from commit 4616e8a)
stephanie-wang pushed a commit to stephanie-wang/ray that referenced this pull request Aug 25, 2021
* ip

* loose check failure

* Fix the bug properly.

* Fix comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants