Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++ Worker]Ignore genrated files #16803

Merged
merged 13 commits into from
Jul 2, 2021

Conversation

qicosmos
Copy link
Contributor

@qicosmos qicosmos commented Jul 1, 2021

Why are these changes needed?

C++ worker will generate a template project, we need to ignore the generated files by c++ worker.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests

@qicosmos qicosmos requested review from kfstorm and SongGuyang July 1, 2021 09:38
Copy link
Contributor

@SongGuyang SongGuyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kfstorm
Copy link
Member

kfstorm commented Jul 2, 2021

CI failures are unrelated.

@kfstorm kfstorm merged commit 7f78e8c into ray-project:master Jul 2, 2021
@kfstorm kfstorm deleted the ignore_genrated_files branch July 2, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants