Skip to content

Conversation

robertnishihara
Copy link
Collaborator

@robertnishihara robertnishihara commented Mar 7, 2018

We should not merge this until #1597 is fixed.

cc @richardliaw

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4182/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4186/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4187/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4188/
Test PASSed.

@richardliaw
Copy link
Contributor

richardliaw commented Mar 9, 2018

We should also to make sure the landing page of docs and readme of the repo are somewhat consistent (I can take care of that)

@robertnishihara
Copy link
Collaborator Author

Makes sense. Are you referring to the code example? I don't think we need to put the nightly pip installs on the doc landing page.

@robertnishihara
Copy link
Collaborator Author

@richardliaw this is certainly visually cleaner, but people won't know what to do with the wheels. We need to tell them to do pip install -U $WHEEL_NAME so I think we should just include the full command.

How about we make a separate documentation page for "Trying the Latest Version" and move it off of the README?

@robertnishihara
Copy link
Collaborator Author

#1597 has been fixed so there is nothing blocking this PR anymore.

@robertnishihara
Copy link
Collaborator Author

Then you should also remove the documentation for installing on Mac, right?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4264/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4265/
Test PASSed.

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine with me but someone else should also review, as I basically took over this PR..

- To build Ray from source, see the instructions for `Ubuntu`_ and `Mac`_.

.. _`Ubuntu`: http://ray.readthedocs.io/en/latest/install-on-ubuntu.html
.. _`Mac`: http://ray.readthedocs.io/en/latest/install-on-macosx.html
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove this documentation page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm is it not removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my mistake.

@robertnishihara
Copy link
Collaborator Author

Looks good to me, I'd suggest merging.

@richardliaw
Copy link
Contributor

Test failures unrelated - lint passes - merging

@richardliaw richardliaw merged commit 15a4392 into ray-project:master Mar 12, 2018
@richardliaw richardliaw deleted the latestwheels branch March 12, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants