-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add instructions for pip installing the latest wheel. #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
We should also to make sure the landing page of docs and readme of the repo are somewhat consistent (I can take care of that) |
Makes sense. Are you referring to the code example? I don't think we need to put the nightly pip installs on the doc landing page. |
@richardliaw this is certainly visually cleaner, but people won't know what to do with the wheels. We need to tell them to do How about we make a separate documentation page for "Trying the Latest Version" and move it off of the README? |
#1597 has been fixed so there is nothing blocking this PR anymore. |
Then you should also remove the documentation for installing on Mac, right? |
Test PASSed. |
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine with me but someone else should also review, as I basically took over this PR..
- To build Ray from source, see the instructions for `Ubuntu`_ and `Mac`_. | ||
|
||
.. _`Ubuntu`: http://ray.readthedocs.io/en/latest/install-on-ubuntu.html | ||
.. _`Mac`: http://ray.readthedocs.io/en/latest/install-on-macosx.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we remove this documentation page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm is it not removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my mistake.
Looks good to me, I'd suggest merging. |
Test failures unrelated - lint passes - merging |
We should not merge this until #1597 is fixed.
cc @richardliaw