[tune] change delimiter for results #16573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
|
@krfricke lmk what you think about this. |
krfricke
reviewed
Jul 2, 2021
| "Dataframes will use '/' instead of '.' to delimit " | ||
| "nested result keys in future versions of Ray. For forward " | ||
| "compatibility, set the environment variable " | ||
| "TUNE_RESULT_NEW_DELIM=1.") |
There was a problem hiding this comment.
TUNE_RESULT_DELIM="." instead?
richardliaw
commented
Jul 10, 2021
krfricke
reviewed
Aug 10, 2021
Comment on lines
544
to
551
| def _delimiter(self): | ||
| delimiter = os.environ.get("TUNE_RESULT_DELIM", "/") | ||
| if delimiter == "/" and log_once("delimiter_deprecation"): | ||
| warnings.warn( | ||
| "Dataframes will use '/' instead of '.' to delimit " | ||
| "nested result keys in future versions of Ray. For forward " | ||
| "compatibility, set the environment variable " | ||
| "TUNE_RESULT_DELIM='.'") |
There was a problem hiding this comment.
Maybe I'm confused here, but shouldn't this be the other way around?
I.e. we use
delimiter = os.environ.get("TUNE_RESULT_DELIM", ".")
because it is the current behavior. Then we check
if delimiter == "." and log_once("delimiter_deprecation"):
because the . will be deprecated, and then we suggest
"nested result keys in future versions of Ray. For forward "
"compatibility, set the environment variable "
"TUNE_RESULT_DELIM='/'")
because / will be used in the future?
krfricke
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We should have a consistent usage of "/" for all dict flattening?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.