[C++ worker] support build and add C++ worker to python wheel #16496
Conversation
| @@ -124,22 +124,23 @@ Ray provides Python, Java, and *EXPERIMENTAL* C++ API. And Ray uses Tasks (funct | |||
| .. code-block:: shell | |||
|
|
|||
| bazel build //cpp:ray_cpp_pkg | |||
| bazel build //cpp/example:example | |||
| cd cpp/example/ | |||
There was a problem hiding this comment.
Can we avoid this, just use one command.
There was a problem hiding this comment.
We need this because example has become an independent bazel project. Do you mean like this cd cpp/example/ && bazel build //:example?
There was a problem hiding this comment.
How about bazel build //cpp/example:example?
Don't need to goto a sub dir.
There was a problem hiding this comment.
If we use build //cpp/example:example, we can not ensure this project is independent. Just like a sub-project under ray project.
|
I'd prefer to stop using the term "example" and "template project". Try with "sample application" instead. |
|
@SongGuyang Can you make the printed message colorful by following the usage of |
|
@kfstorm The code has been updated and already used cli_logger. |
| @@ -205,7 +205,7 @@ test_cpp() { | |||
| bazel test //cpp:cluster_mode_test --test_arg=--external-cluster=true --test_arg=--redis-password="1234" \ | |||
| --test_arg=--ray-redis-password="1234" | |||
| # run the cpp example | |||
| bazel run //cpp/example:example | |||
| cd cpp/example && bazel --nosystem_rc --nohome_rc run //:example | |||
There was a problem hiding this comment.
What problem does --nosystem_rc --nohome_rc solve? Should we add these to the doc?
There was a problem hiding this comment.
Bazel options has been inherited in CI images. But this test is an independent project for users. We need add "--nosystem_rc --nohome_rc" in the test script. But we don't need to add this to the doc because there is no problem in user side.
|
test_multi_tenancy timeout should be unrelated. |
Why are these changes needed?
support get a c++ library for ray script, like this:
ray cpp --show-library-path
ray cpp --generate-bazel-project-template-to {your_dir}
support build c++ API to wheel when you set environment variable
export RAY_INSTALL_CPP=1