-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] update to expose libraries + landing page #1642
Conversation
Test FAILed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Somehow it might be nice to indicate that HyperBand isn't a library, as with PBT. I do believe these things are worth highlighting and am not sure about the right formatting. @robertnishihara @pcmoritz @concretevitamin @vlad17 any thoughts? |
Yeah I don't know if readthedocs has some syntax for a nested page. |
seems good to me |
Test PASSed. |
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericl, should do a read over my changes before merge
doc/source/hyperband.rst
Outdated
Asynchronous HyperBand | ||
---------------------- | ||
|
||
Ray Tune also implements an `asynchronous version of HyperBand <https://openreview.net/forum?id=S1Y7OOlRZ>`__, providing better parallelism and avoids straggler issues during eliminations. An example of this can be found in `async_hyperband_example.py <https://github.com/ray-project/ray/blob/master/python/ray/tune/examples/async_hyperband_example.py>`__. **We recommend using this over the vanilla HyperBand scheduler.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we recommend this as the default one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reordered the docs so that it shows up first
doc/source/hyperband.rst
Outdated
|
||
.. image:: images/hyperband_eta.png | ||
|
||
We figured that it would be a lot easier for majority of people to use if we fixed the parameters to be the same as the example given in the paper and only exposed `max_t`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This phrasing sounds more like a blog post, reword for documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple comments on phrasing
addressed comments and tweaked a little more; I'll merge for now after tests pass(as there are no substantial changes) but if there are issues we can just patch it. |
Sounds good! |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
What do these changes do?
This reorganizes the tune docs to give important algorithms their own page (we should add more as new algorithms are added). This should hopefully help with SEO -- currently if you search for "HyperBand" the tune docs don't even show up in the first couple pages. However if you search for "A3C" or "Rllib" those terms already rank highly.