Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Flake8 upgrade #15527

Merged
merged 21 commits into from
May 3, 2021
Merged

[CI] Flake8 upgrade #15527

merged 21 commits into from
May 3, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Apr 27, 2021 •
edited
Loading

Upgrade flake8 version to 3.9.1

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam amogkam marked this pull request as ready for review April 29, 2021 17:30
@amogkam amogkam changed the title [WIP] Flake8 upgrade [CI] Flake8 upgrade Apr 29, 2021
@amogkam
Copy link
Contributor Author

amogkam commented Apr 29, 2021

@sven1977 can you take a quick pass over the rllib typing changes please

@amogkam
Copy link
Contributor Author

amogkam commented May 3, 2021

Bump on this @simon-mo @sven1977

simon-mo
simon-mo approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amogkam
Copy link
Contributor Author

amogkam commented May 3, 2021

test_actor is a known flaky test. Going to merge this.

@amogkam amogkam merged commit ebc44c3 into ray-project:master May 3, 2021
@amogkam amogkam deleted the flake8-upgrade branch May 3, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@sven1977 sven1977

@simon-mo simon-mo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amogkam @simon-mo @sven1977