Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Enable gitpod #15420

Merged
merged 7 commits into from
Apr 21, 2021
Merged

[dev] Enable gitpod #15420

merged 7 commits into from
Apr 21, 2021

Conversation

fishbone
Copy link
Contributor

Why are these changes needed?

I'd like to merge these changes for gitpod to test the doability of leveraging gitpod to reduce develop barrier.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo
Copy link
Contributor

Is python/package-lock.json essential? Can we remove it. Everything else looks good.

@fishbone
Copy link
Contributor Author

Good catch! It got hided and I didn't even notice it.

@fishbone
Copy link
Contributor Author

@simon-mo is it good for a merge?

@fishbone fishbone added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Apr 21, 2021
@simon-mo simon-mo merged commit 0fa6bae into ray-project:master Apr 21, 2021
@fishbone fishbone deleted the init-gitpod branch May 11, 2021 23:48
@rickyyx rickyyx mentioned this pull request Dec 29, 2022
7 tasks
scv119 pushed a commit that referenced this pull request Jan 5, 2023
Reverting changes from #15420 so that we no longer need to update the Dockerfile here with python upgrade and dependency changes.
Signed-off-by: rickyyx <rickyx@anyscale.com>
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
Reverting changes from #15420 so that we no longer need to update the Dockerfile here with python upgrade and dependency changes.
Signed-off-by: rickyyx <rickyx@anyscale.com>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
Reverting changes from ray-project#15420 so that we no longer need to update the Dockerfile here with python upgrade and dependency changes.
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants