Skip to content

Add actor reconstruction limitations to documentation #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

stephanie-wang
Copy link
Contributor

This documents the corner case for new tasks getting interleaved with re-executed tasks during actor reconstruction.

@@ -58,3 +58,9 @@ Lost Objects
evicted, and is later needed, Ray will not reconstruct this object.
2. If an object is constructed by an actor method, is then evicted, and is later
needed, Ray will not reconstruct this object.

Actor Reconstruction
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this really belongs under "Unhandled Failures". Maybe it should be under "Actors"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought it would go better here since the other limitation for actors (no reconstruction for evicted objects) is also listed here, in the above subsection. Should I move it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why don't we leave it here and just change the name "Unhandled Failures" to "Current Limitations" or something like that?

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3339/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3340/
Test PASSed.

@stephanie-wang stephanie-wang merged commit fb4d991 into ray-project:master Jan 23, 2018
@stephanie-wang stephanie-wang deleted the reconstruction-doc branch February 19, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants