-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add actor reconstruction limitations to documentation #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actor reconstruction limitations to documentation #1452
Conversation
@@ -58,3 +58,9 @@ Lost Objects | |||
evicted, and is later needed, Ray will not reconstruct this object. | |||
2. If an object is constructed by an actor method, is then evicted, and is later | |||
needed, Ray will not reconstruct this object. | |||
|
|||
Actor Reconstruction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this really belongs under "Unhandled Failures". Maybe it should be under "Actors"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I thought it would go better here since the other limitation for actors (no reconstruction for evicted objects) is also listed here, in the above subsection. Should I move it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, why don't we leave it here and just change the name "Unhandled Failures" to "Current Limitations" or something like that?
Merged build finished. Test PASSed. |
Test PASSed. |
Merged build finished. Test PASSed. |
Test PASSed. |
This documents the corner case for new tasks getting interleaved with re-executed tasks during actor reconstruction.