[autoscaler] Fix confirmation (y/N) for autoscaler for Python 2 #1450
Conversation
pcmoritz
changed the title
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
python/ray/autoscaler/commands.py
Outdated
| @@ -171,7 +171,10 @@ def get_or_create_head_node(config, no_restart): | |||
|
|
|||
| def confirm(msg): | |||
| print("{}. Do you want to continue [y/N]? ".format(msg), end="") | |||
| answer = input() | |||
| if sys.version_info[0] > 2: | |||
There was a problem hiding this comment.
it would be more consistent with the rest of the codebase to do
if sys.version_info >= (3, 0):
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
python/ray/autoscaler/commands.py
Outdated
| if sys.version_info >= (3, 0): | ||
| answer = input() | ||
| else: | ||
| answer = raw_input() # noqa: F821 |
There was a problem hiding this comment.
two spaces before comments.. this will probably be another linting error
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
What do these changes do?
This is a small fix to make the confirmation question work as expected in Python 2. There is a small inconsistency between Python 2 and Python 3 input (namely in Python 2 the result is evaled), which gives a "no such variable y" error in Python 2.
Without this fix, the user has to type 'y' instead of y to make sure the result of eval is a string.