[Core]Fix ray.kill doesn't cancel pending actor bug #14025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
February 2, 2021 11:14
simon-mo
approved these changes
Feb 10, 2021
rkooo567
approved these changes
Feb 10, 2021
|
@rkooo567 The failure of ci job seems unrelated, i will merge it. |
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ect#14025)" This reverts commit cbfa543.
architkulkarni
added a commit
that referenced
this pull request
Feb 17, 2021
This reverts commit 1754359.
ericl
pushed a commit
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, ray.kill doesn't cancel pending actor creation request in raylet. So we add DestroyActor api in gcs and call lease_client->CancelWorkerLease in gcs actor scheduler to cancel actor creation request.
Related issue number
#13214
Checks
scripts/format.shto lint the changes in this PR.