[autoscaler][kubernetes] autoscaling hotfix #14024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Right now Kubernetes fill_out_available_node_type_resources logic fills "GPU":0 for non-gpu nodes, which interacts badly with the resource demand scheduler's gpu conservation logic, preventing autoscaling on k8s.
This fixes KubernetesNodeProvider's resource-filling logic to not fill fields with value 0.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.Did quick manual check that this fixes the problem.
Will add more test logic to the K8s operator unit test (not currently in CI) later.