Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Master compilation error on MacOS. #13946

Merged
merged 3 commits into from
Feb 6, 2021

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Feb 5, 2021

Ray won't compile on mac:


Use --sandbox_debug to see verbose messages from the sandbox
src/ray/core_worker/reference_count.cc:1013:19: error: loop variable 'callback' of type 'const std::__1::function<void (const absl::lts_2019_08_08::flat_hash_set<ray::NodeID, absl::lts_2019_08_08::hash_internal::Hash<ray::NodeID>, std::__1::equal_to<ray::NodeID>, std::__1::allocator<ray::NodeID> > &, long long, long long)>' creates a copy from type 'const std::__1::function<void (const absl::lts_2019_08_08::flat_hash_set<ray::NodeID, absl::lts_2019_08_08::hash_internal::Hash<ray::NodeID>, std::__1::equal_to<ray::NodeID>, std::__1::allocator<ray::NodeID> > &,
  0 [Hotfix] Master compile and dask test
 long long, long long)>' [-Werror,-Wrange-loop-analysis]
  for (const auto callback : callbacks) {
                  ^
src/ray/core_worker/reference_count.cc:1013:8: note: use reference type 'const std::__1::function<void (const absl::lts_2019_08_08::flat_hash_set<ray::NodeID, absl::lts_2019_08_08::hash_internal::Hash<ray::NodeID>, std::__1::equal_to<ray::NodeID>, std::__1::allocator<ray::NodeID> > &, long long, long long)> &' to prevent copying
  for (const auto callback : callbacks) {
       ^~~~~~~~~~~~~~~~~~~~~
                  &
1 error generated.
Target //:ray_pkg failed to build
INFO: Elapsed time: 11.263s, Critical Path: 10.72s
INFO: 2 processes: 2 darwin-sandbox.

@simon-mo simon-mo merged commit ea4154d into ray-project:master Feb 6, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants