[tune] Fixed wait_for_gpu to handle str representations of ordinal IDs #13936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Feb 5, 2021
richardliaw
reviewed
Feb 5, 2021
richardliaw
changed the title
ANarayan
reviewed
Feb 5, 2021
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
ray-project#13936) Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…dinal IDs (ray-project#13936)" This reverts commit 35e20cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
wait_for_gpusdoes not handle the case when the user passes in an ordinal GPU ID as a string, which is the format returned byray.get_gpu_ids(). As such, the default behavior of this function whengpu_id=Noneis currently broken.Related issue number
#13486.
Checks
scripts/format.shto lint the changes in this PR.cc @richardliaw