Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] Pull out multi-gpu optimizer as a generic class #1313

Merged
merged 43 commits into from
Dec 17, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
49dd02b
interface file
ericl Nov 21, 2017
cd50cdd
add dqn evaluator
ericl Nov 21, 2017
c5ef83e
Mon Nov 20 17:44:44 PST 2017
ericl Nov 21, 2017
3005f9e
implement more
ericl Nov 21, 2017
95b62c7
optdoc
ericl Nov 21, 2017
caed1df
add base eval
ericl Nov 22, 2017
00e1e1c
Wed Nov 29 14:27:56 PST 2017
ericl Nov 29, 2017
d1e6570
Merge remote-tracking branch 'upstream/master' into evaluator
ericl Nov 29, 2017
173e845
update dqn eval
ericl Nov 30, 2017
edadd65
doc optimizers
ericl Nov 30, 2017
edb17de
fix up graph
ericl Nov 30, 2017
293becc
move optimizers
ericl Nov 30, 2017
0f17fde
implement async optimizer
ericl Nov 30, 2017
bab5010
add async mode dqn test
ericl Nov 30, 2017
8b5b1a0
update
ericl Nov 30, 2017
de44c91
2 workers in test
ericl Nov 30, 2017
9839db3
wip need to make build_loss reuse the vars properly
ericl Nov 30, 2017
7e1f9e2
wip sample batches
ericl Nov 30, 2017
b9764c2
wip
ericl Nov 30, 2017
48a349c
cleanup some
ericl Nov 30, 2017
916f25b
review comments
ericl Dec 4, 2017
85cfe8d
Merge remote-tracking branch 'upstream/master' into evaluator
ericl Dec 4, 2017
191b159
remove logger
ericl Dec 6, 2017
1c4ef0d
make yamld ep soft
ericl Dec 6, 2017
c8acce0
fix importer
ericl Dec 6, 2017
2043a04
Merge branch 'evaluator' into evaluator-multi-gpu
ericl Dec 11, 2017
1e223e8
Merge remote-tracking branch 'upstream/master' into evaluator
ericl Dec 11, 2017
cf2eabd
Merge branch 'evaluator' into evaluator-multi-gpu
ericl Dec 11, 2017
e36dafd
fix serialization issues with sample batches
ericl Dec 12, 2017
05fca04
multi gpu now working
ericl Dec 12, 2017
636bf9e
add test
ericl Dec 12, 2017
f743ac8
move evaluator
ericl Dec 12, 2017
44ec06e
doc
ericl Dec 12, 2017
ee7e606
update docs some
ericl Dec 12, 2017
c069491
Merge remote-tracking branch 'upstream/master' into evaluator-multi-gpu
ericl Dec 14, 2017
e9b21c8
Wed Dec 13 17:40:11 PST 2017
ericl Dec 14, 2017
bbf6ebf
better err msg
ericl Dec 14, 2017
ff4b416
add tuned result
ericl Dec 15, 2017
d35a818
comments
ericl Dec 15, 2017
5e14b5e
Merge remote-tracking branch 'upstream/master' into evaluator-multi-gpu
ericl Dec 15, 2017
c9aa526
fix a3c import
ericl Dec 15, 2017
2e5bda1
Merge remote-tracking branch 'upstream/master' into evaluator-multi-gpu
ericl Dec 15, 2017
9906c54
fix jenkins
ericl Dec 17, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move evaluator
  • Loading branch information
ericl committed Dec 12, 2017
commit f743ac8500f6d17d345d6d23f767200f3c910ab0
3 changes: 1 addition & 2 deletions python/ray/rllib/dqn/base_evaluator.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
from ray.rllib.dqn import models
from ray.rllib.dqn.common.wrappers import wrap_dqn
from ray.rllib.dqn.common.schedules import LinearSchedule
from ray.rllib.evaluator import TFMultiGPUSupport
from ray.rllib.optimizers import SampleBatch
from ray.rllib.optimizers import SampleBatch, TFMultiGPUSupport


class DQNEvaluator(TFMultiGPUSupport):
Expand Down
3 changes: 2 additions & 1 deletion python/ray/rllib/optimizers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
from ray.rllib.optimizers.local_sync import LocalSyncOptimizer
from ray.rllib.optimizers.multi_gpu import LocalMultiGPUOptimizer
from ray.rllib.optimizers.sample_batch import SampleBatch
from ray.rllib.optimizers.evaluator import Evaluator, TFMultiGPUSupport


__all__ = [
"AsyncOptimizer", "LocalSyncOptimizer", "LocalMultiGPUOptimizer",
"SampleBatch"]
"SampleBatch", "Evaluator", "TFMultiGPUSupport"]
File renamed without changes.
2 changes: 1 addition & 1 deletion python/ray/rllib/optimizers/multi_gpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import tensorflow as tf

import ray
from ray.rllib.evaluator import TFMultiGPUSupport
from ray.rllib.optimizers.evaluator import TFMultiGPUSupport
from ray.rllib.optimizers.optimizer import Optimizer
from ray.rllib.optimizers.sample_batch import SampleBatch
from ray.rllib.parallel import LocalSyncParallelOptimizer
Expand Down