Don't release resources during plasma fetch #13025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,6 +274,10 @@ RAY_CONFIG(int32_t, minimum_gcs_reconnect_interval_milliseconds, 5000) | |||
| /// Whether start the Plasma Store as a Raylet thread. | |||
| RAY_CONFIG(bool, plasma_store_as_thread, false) | |||
|
|
|||
| /// Whether to release worker CPUs during plasma fetches. | |||
| /// See https://github.com/ray-project/ray/issues/12912 for further discussion. | |||
| RAY_CONFIG(bool, release_resources_during_plasma_fetch, false) | |||
There was a problem hiding this comment.
Do we still need this flag? I can't really think of any cases where we would want this to be true.
There was a problem hiding this comment.
It's here just in case we want to easily disable it (feature flag).
stephanie-wang
approved these changes
Dec 21, 2020
| @@ -563,5 +563,59 @@ def test_fusion_objects(tmp_path, shutdown_only): | |||
| assert is_test_passing | |||
|
|
|||
|
|
|||
| # https://github.com/ray-project/ray/issues/12912 | |||
| def do_test_release_resource(tmp_path, expect_released): | |||
There was a problem hiding this comment.
You could also parametrize the test with True/False for expect_released.
rkooo567
approved these changes
Dec 21, 2020
|
Yeah, I think we can clean up the call names in a later PR (avoid refactoring and feature changes in the same PR). |
cathrinS
pushed a commit
to cathrinS/ray
that referenced
this pull request
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This implements the change proposed in #12912 in a minimal way. It also cleans up the core worker a bit, removing unused flags.