Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch debugger to sockets and support unicode #13004

Merged
merged 5 commits into from
Dec 20, 2020

Conversation

pcmoritz
Copy link
Contributor

Why are these changes needed?

This PR switches the Ray debugger client from telnet to sockets so we can support unicode characters in the source code.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! does this mean we can add ipdb next :)

@pcmoritz
Copy link
Contributor Author

Yeah, first we need to get tab completion working (which is actually supported by both pdb and ipdb).

Since the tab completion information is only available in the remote process (naturally), to make it available in the client, we need to both flush the stdin of the client as well as the socket that connects it to the remote process as soon as we encounter a tab. This turns out to be more involved than anticipated because there is some buffering in place for both at the moment, I'll keep working on it tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants