Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continue for debugger #12862

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Fix continue for debugger #12862

merged 1 commit into from
Dec 17, 2020

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Dec 15, 2020 •
edited
Loading

Why are these changes needed?

This PR makes it so the debugger drops back into the main debug loop when the user continues the execution of a task with the "continue" or "c" command.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz pcmoritz requested a review from yifeif December 15, 2020 01:40
yifeif
yifeif approved these changes Dec 15, 2020
View reviewed changes
Copy link

@yifeif yifeif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@pcmoritz pcmoritz added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 16, 2020
@richardliaw richardliaw merged commit ad036fd into ray-project:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yifeif yifeif yifeif approved these changes

Assignees
No one assigned
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcmoritz @yifeif @richardliaw