Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PlacementGroup]Support acquire and return bundle resource from gcs resource manager #12349

Merged
merged 14 commits into from
Dec 8, 2020
Merged

[PlacementGroup]Support acquire and return bundle resource from gcs resource manager #12349

merged 14 commits into from
Dec 8, 2020

Conversation

ffbin
Copy link
Contributor

@ffbin ffbin commented Nov 24, 2020 •
edited
Loading

Why are these changes needed?

When we enable the lightweight heartbeat and schedule multiple placement group continuously, the placement group scheduling maybe fail because the cluster resource view is not updated in time. Therefore, we modify the cluster resource view in this PR, which is also prepared for actor scheduling optimization, because it also needs to update the resource view.
Actor scheduling and placement group scheduling will use the same resource view.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ffbin ffbin added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Nov 25, 2020
@ffbin ffbin force-pushed the return_resource_when_rm_pg branch from c81d6d4 to 4dff7bc Compare November 25, 2020 07:04
@ffbin ffbin force-pushed the return_resource_when_rm_pg branch from 4dff7bc to b63791e Compare December 4, 2020 13:09
@ffbin ffbin changed the title [WIP][PlacementGroup]Return bundle resource when remove placement group [PlacementGroup]Support acquire and return bundle resource from gcs resource manager Dec 5, 2020
@ffbin ffbin removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 5, 2020
@ffbin ffbin requested review from rkooo567 and raulchen December 5, 2020 12:01
wumuzi520
wumuzi520 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@wumuzi520 wumuzi520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raulchen raulchen merged commit 93c0eb2 into ray-project:master Dec 8, 2020
@raulchen raulchen deleted the return_resource_when_rm_pg branch December 8, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@wumuzi520 wumuzi520 wumuzi520 approved these changes

@rkooo567 rkooo567 Awaiting requested review from rkooo567

Assignees

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffbin @wumuzi520 @raulchen @rkooo567