Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all config constants into single file. #1192

Merged
merged 18 commits into from
Nov 8, 2017
Merged

Move all config constants into single file. #1192

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
336adf5
Initial pass at factoring out C++ configuration into a single file.
robertnishihara Nov 7, 2017
9945785
Expose config through Python.
robertnishihara Nov 8, 2017
7278d1b
Forward declarations.
robertnishihara Nov 8, 2017
7469f50
Fixes with Python extensions
robertnishihara Nov 8, 2017
8962982
Remove old code.
robertnishihara Nov 8, 2017
0e72b86
Consistent naming for constants.
robertnishihara Nov 8, 2017
f354ed3
Fixes
robertnishihara Nov 8, 2017
eb0b9b1
Fix linting.
robertnishihara Nov 8, 2017
8afba7e
More linting.
robertnishihara Nov 8, 2017
a2f8307
Whitespace
robertnishihara Nov 8, 2017
357f0a4
rename config -> _config.
robertnishihara Nov 8, 2017
8204111
Move config inside a class.
robertnishihara Nov 8, 2017
2dc56dc
update naming convention
robertnishihara Nov 8, 2017
c3b6602
Fix linting.
robertnishihara Nov 8, 2017
a2bf821
More linting
robertnishihara Nov 8, 2017
fee1d49
More linting.
robertnishihara Nov 8, 2017
f409265
Add in some more constants.
robertnishihara Nov 8, 2017
94ff32d
Fix linting
robertnishihara Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More linting
  • Loading branch information
@robertnishihara
robertnishihara committed Nov 8, 2017
commit a2bf821a7b95a9a32e115415277e95af0b70b2cb
8 changes: 4 additions & 4 deletions src/common/lib/python/common_extension.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,8 +545,8 @@ int is_simple_value(PyObject *value, int *num_elements_contained) {
return (*num_elements_contained <
RayConfig::instance().num_elements_limit());
}
if (PyList_CheckExact(value) && PyList_Size(value) <
RayConfig::instance().size_limit()) {
if (PyList_CheckExact(value) &&
PyList_Size(value) < RayConfig::instance().size_limit()) {
for (Py_ssize_t i = 0; i < PyList_Size(value); ++i) {
if (!is_simple_value(PyList_GetItem(value, i), num_elements_contained)) {
return 0;
Expand All @@ -555,8 +555,8 @@ int is_simple_value(PyObject *value, int *num_elements_contained) {
return (*num_elements_contained <
RayConfig::instance().num_elements_limit());
}
if (PyDict_CheckExact(value) && PyDict_Size(value) <
RayConfig::instance().size_limit()) {
if (PyDict_CheckExact(value) &&
PyDict_Size(value) < RayConfig::instance().size_limit()) {
PyObject *key, *val;
Py_ssize_t pos = 0;
while (PyDict_Next(value, &pos, &key, &val)) {
Expand Down