Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Move all /latest links to /master #11897

Merged
merged 6 commits into from
Nov 10, 2020
Merged

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Nov 10, 2020

Why are these changes needed?

Since latest is a hidden doc version, move them to master. Remove the banner warning from master but keep it for latest (telling users to go to /master).

@@ -67,7 +67,7 @@ head_node:
# Provider-specific config for worker nodes, e.g. instance type. By default
# Ray will auto-configure unspecified fields such as SubnetId and KeyName.
# For more documentation on available fields, see:
# http://boto3.readthedocs.io/en/latest/reference/services/ec2.html#EC2.ServiceResource.create_instances
# http://boto3.readthedocs.io/en/master/reference/services/ec2.html#EC2.ServiceResource.create_instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep

@@ -50,7 +50,7 @@ auth:
# Provider-specific config for the head node, e.g. instance type. By default
# Ray will auto-configure unspecified fields such as SubnetId and KeyName.
# For more documentation on available fields, see:
# http://boto3.readthedocs.io/en/latest/reference/services/ec2.html#EC2.ServiceResource.create_instances
# http://boto3.readthedocs.io/en/master/reference/services/ec2.html#EC2.ServiceResource.create_instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep

@@ -4,7 +4,7 @@ name: ray-example-newsreader

description: "A simple news reader example that uses ray actors to serve requests"
tags: ["ray-example", "flask", "rss", "newsreader"]
documentation: https://docs.ray.io/en/latest/auto_examples/plot_newsreader.html
documentation: https://docs.ray.io/en/master/auto_examples/plot_newsreader.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should just get rid of all of these ray-project/* things

@@ -41,7 +41,7 @@ auth:
# Provider-specific config for the head node, e.g. instance type. By default
# Ray will auto-configure unspecified fields such as SubnetId and KeyName.
# For more documentation on available fields, see:
# http://boto3.readthedocs.io/en/latest/reference/services/ec2.html#EC2.ServiceResource.create_instances
# http://boto3.readthedocs.io/en/master/reference/services/ec2.html#EC2.ServiceResource.create_instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert all boto links

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all links that are non-ray related

@@ -41,7 +41,7 @@ auth:
# Provider-specific config for the head node, e.g. instance type. By default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert all boto links

@@ -62,7 +62,7 @@ def scheduler_dicts(self):
returns scheduler objects.

See
https://pytorch-lightning.readthedocs.io/en/latest/lightning_module.html#configure-optimizers
https://pytorch-lightning.readthedocs.io/en/master/lightning_module.html#configure-optimizers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@@ -75,7 +75,7 @@ async def _handle_system_request(self, scope, receive, send):

async def __call__(self, scope, receive, send):
# NOTE: This implements ASGI protocol specified in
# https://asgi.readthedocs.io/en/latest/specs/index.html
# https://asgi.readthedocs.io/en/master/specs/index.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@@ -73,7 +73,7 @@ auth:
# Provider-specific config for the head node, e.g. instance type. By default
# Ray will auto-configure unspecified fields such as SubnetId and KeyName.
# For more documentation on available fields, see:
# http://boto3.readthedocs.io/en/latest/reference/services/ec2.html#EC2.ServiceResource.create_instances
# http://boto3.readthedocs.io/en/master/reference/services/ec2.html#EC2.ServiceResource.create_instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@@ -57,7 +57,7 @@ burden and speedup review process.

pytest ray/python/ray/tune/tests/

Documentation should be documented in `Google style <https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html>`__ format.
Documentation should be documented in `Google style <https://sphinxcontrib-napoleon.readthedocs.io/en/master/example_google.html>`__ format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@@ -485,5 +485,5 @@ Further References
------------------

* `XGBoost Hyperparameter Tuning - A Visual Guide <https://kevinvecmanis.io/machine%20learning/hyperparameter%20tuning/dataviz/python/2019/05/11/XGBoost-Tuning-Visual-Guide.html>`_
* `Notes on XGBoost Parameter Tuning <https://xgboost.readthedocs.io/en/latest/tutorials/param_tuning.html>`_
* `Notes on XGBoost Parameter Tuning <https://xgboost.readthedocs.io/en/master/tutorials/param_tuning.html>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@@ -121,7 +121,7 @@ is a ``dict`` in which you can specify parameters for the XGBoost algorithm. In
simple example, the only parameters we passed are the ``objective`` and ``eval_metric`` parameters.
The value ``binary:logistic`` tells XGBoost that we aim to train a logistic regression model for
a binary classification task. You can find an overview over all valid objectives
`here in the XGBoost documentation <https://xgboost.readthedocs.io/en/latest/parameter.html#learning-task-parameters>`_.
`here in the XGBoost documentation <https://xgboost.readthedocs.io/en/master/parameter.html#learning-task-parameters>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Copy link
Contributor Author

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ericl ericl added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Nov 10, 2020
@ericl
Copy link
Contributor Author

ericl commented Nov 10, 2020

Ping @richardliaw

@ericl ericl merged commit 9b8218a into ray-project:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants