[GCS]Fix TestActorTableResubscribe bug #11830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffbin
commented
Nov 5, 2020
| auto condition = [&num_subscribe_all_notifications]() { | ||
| return num_subscribe_all_notifications == 3 || num_subscribe_all_notifications == 4; | ||
| }; | ||
| EXPECT_TRUE(WaitForCondition(condition, timeout_ms_.count())); |
There was a problem hiding this comment.
Fix TestActorTableResubscribe bug
ffbin
changed the title
rkooo567
approved these changes
Nov 6, 2020
|
Can you merge the latest master? I am seeing the test failure from |
rkooo567
added
the
@author-action-required
ffbin
force-pushed
the
fix_compile_bug
branch
from
f1888b1 to
675d0f4
Compare
ffbin
removed
the
@author-action-required
Hi @rkooo567 , please help take a look, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix TestActorTableResubscribe bug.
Related issue number
#11640 (comment)
Checks
scripts/format.shto lint the changes in this PR.