Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Add dashboard multi-node churn test #11768

Merged
merged 10 commits into from
Dec 14, 2020
Merged

[Dashboard] Add dashboard multi-node churn test #11768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b6bbbf
add new test
mfitton Oct 29, 2020
9c08438
fix lint
mfitton Nov 9, 2020
a1c1430
attempt to stop new test from timing out in ci
mfitton Nov 10, 2020
7390184
Address flaky tests
mfitton Nov 30, 2020
b588a31
Merge branch 'master' into new-multi-node-test
mfitton Dec 2, 2020
32c72ea
increase timeout for test that has been flaky
mfitton Dec 2, 2020
699c87c
make test even shorter
mfitton Dec 3, 2020
f64130d
Make dashboard bazel timeout longer and make the stats collector chur…
mfitton Dec 3, 2020
5ee1843
try to fix BUILD file
mfitton Dec 11, 2020
170cfc2
Also make test_dashboard a medium-size test
mfitton Dec 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address flaky tests
  • Loading branch information
@mfitton
mfitton committed Nov 30, 2020
commit 7390184eebc5e1da1b240b012204199c85cc2542
1 change: 1 addition & 0 deletions dashboard/modules/stats_collector/tests/test_stats_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ def get_nodes():
duration = timedelta(seconds=30)
while datetime.now() < t_st + duration:
get_index()
time.sleep(2)


if __name__ == "__main__":
Expand Down
2 changes: 1 addition & 1 deletion dashboard/tests/test_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def test_basic(ray_start_with_dashboard):
0]
dashboard_proc = psutil.Process(dashboard_proc_info.process.pid)
assert dashboard_proc.status() in [
psutil.STATUS_RUNNING, psutil.STATUS_SLEEPING
psutil.STATUS_RUNNING, psutil.STATUS_SLEEPING, psutil.STATUS_DISK_SLEEP
]
raylet_proc_info = all_processes[ray_constants.PROCESS_TYPE_RAYLET][0]
raylet_proc = psutil.Process(raylet_proc_info.process.pid)
Expand Down