[tune] logger refactor part 1: move classes and utilities to own files #11746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
7 tasks
richardliaw
reviewed
Nov 3, 2020
richardliaw
reviewed
Nov 3, 2020
| @@ -457,7 +457,8 @@ def run_experiments(experiments, | |||
| reuse_actors=False, | |||
| trial_executor=None, | |||
| raise_on_failed_trial=True, | |||
| concurrent=True): | |||
| concurrent=True, | |||
| callbacks=None): | |||
There was a problem hiding this comment.
Seems fine to leave it (or remove), but don't forget to docstring
There was a problem hiding this comment.
Hm, the run_experiments doesn't seem to have a docstring at all. It is documented at run() though, like the other arguments. I can add a docstring to run_experiments if that'd help
richardliaw
reviewed
Nov 3, 2020
richardliaw
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
First split of PR #11699
Checks
scripts/format.shto lint the changes in this PR.