Skip to content

[Core]Fix get workrer table bug #11516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 30, 2020
Merged

[Core]Fix get workrer table bug #11516

merged 22 commits into from
Oct 30, 2020

Conversation

clay4megtr
Copy link
Contributor

Why are these changes needed?

Fix get workrer table bug

Related issue number

#11514

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clay4megtr clay4megtr requested review from ffbin and rkooo567 October 21, 2020 05:07
@clay4megtr clay4megtr changed the title Fix get workrer table bug [Core]Fix get workrer table bug Oct 21, 2020
rkooo567
rkooo567 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment!

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 21, 2020
ffbin
ffbin reviewed Oct 21, 2020
View reviewed changes
chaokunyang
chaokunyang reviewed Oct 23, 2020
View reviewed changes
chaokunyang
chaokunyang reviewed Oct 23, 2020
View reviewed changes
chaokunyang
chaokunyang approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkooo567
Copy link
Contributor

Please don't merge it until #11516 (comment) is resolved! I will merge the PR.

rkooo567
rkooo567 reviewed Oct 26, 2020
View reviewed changes
rkooo567
rkooo567 requested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a couple more issues I found.

@clay4megtr
Copy link
Contributor Author

There is a couple more issues I found.

hi, @rkooo567 , I have update the is_alive field in core_worker.cc, maybe you can check it again, thanks~

@clay4megtr clay4megtr added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Oct 30, 2020
@rkooo567 rkooo567 merged commit b10871a into ray-project:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

@ffbin ffbin ffbin approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@ffbin ffbin

@rkooo567 rkooo567

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clay4megtr @rkooo567 @chaokunyang @ffbin