Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix pip install commands #11326

Merged
merged 1 commit into from
Oct 12, 2020
Merged

[docs] Fix pip install commands #11326

merged 1 commit into from
Oct 12, 2020

Conversation

akotlar
Copy link
Contributor

@akotlar akotlar commented Oct 10, 2020 •
edited
Loading

Why are these changes needed?

Installation instructions, as provided, don't work in bash; brackets trigger a pattern matching (glob) operation. This change fixes that, and brings all pip install commands inline with the quoted form shown for ray serve: pip install "ray[serve]"

Related issue number

None

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sumanthratna sumanthratna changed the title Fix install [docs] Fix pip install commands Oct 11, 2020
simon-mo
simon-mo approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simon-mo simon-mo merged commit f9a29a6 into ray-project:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumanthratna sumanthratna sumanthratna approved these changes

@simon-mo simon-mo simon-mo approved these changes

Assignees

@simon-mo simon-mo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akotlar @simon-mo @sumanthratna