-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update arrow to include pandas serialization #1102
Update arrow to include pandas serialization #1102
Conversation
python/ray/worker.py
Outdated
return { | ||
'type': 'Series', | ||
'data': serialized.to_pybytes() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is off here
python/ray/worker.py
Outdated
'data': serialized.to_pybytes() | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too much white space between these functions, should be one line, run flake8 worker.py
.
27442cc
to
558bd1d
Compare
Merged build finished. Test PASSed. |
Test PASSed. |
Merged build finished. Test PASSed. |
Test PASSed. |
Merged build finished. Test PASSed. |
Test PASSed. |
We could also just use the pyarrow default context. And we could add our defaultdict and OrderedDict custom serializers to the default context. What do you think about that? |
Yeah, I'm planning on doing that and putting everything into the default context in arrow and getting rid of most of our code; this will require another PR to arrow. |
No description provided.