Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arrow to include pandas serialization #1102

Merged
merged 2 commits into from
Oct 11, 2017

Conversation

pcmoritz
Copy link
Contributor

No description provided.

return {
'type': 'Series',
'data': serialized.to_pybytes()
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is off here

'data': serialized.to_pybytes()
}


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much white space between these functions, should be one line, run flake8 worker.py.

@pcmoritz pcmoritz force-pushed the pandas-serialization branch from 27442cc to 558bd1d Compare October 11, 2017 03:43
@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/2080/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/2081/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/2082/
Test PASSed.

@robertnishihara
Copy link
Collaborator

We could also just use the pyarrow default context. And we could add our defaultdict and OrderedDict custom serializers to the default context. What do you think about that?

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Oct 11, 2017

Yeah, I'm planning on doing that and putting everything into the default context in arrow and getting rid of most of our code; this will require another PR to arrow.

@robertnishihara robertnishihara merged commit 0684258 into ray-project:master Oct 11, 2017
@robertnishihara robertnishihara deleted the pandas-serialization branch October 11, 2017 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants