Skip to content

Switch to monotonic clock #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

stephanie-wang
Copy link
Contributor

This PR switches from std::chrono::system_clock to std::chrono::steady_clock, so that current_time will always be monotonically increasing. This should fix these occasional Travis errors:

[FATAL] (/home/travis/build/ray-project/ray/src/plasma/plasma_manager.cc:1476: errno: Operation now in progress) Check failure: current_time >= state->previous_heartbeat_time 

/home/travis/.local/lib/python2.7/site-packages/ray-0.2.1-py2.7-linux-x86_64.egg/ray/plasma/../core/src/plasma/plasma_manager[0x4041ac]
/home/travis/.local/lib/python2.7/site-packages/ray-0.2.1-py2.7-linux-x86_64.egg/ray/plasma/../core/src/plasma/plasma_manager[0x421084]
/home/travis/.local/lib/python2.7/site-packages/ray-0.2.1-py2.7-linux-x86_64.egg/ray/plasma/../core/src/plasma/plasma_manager[0x42131b]
/home/travis/.local/lib/python2.7/site-packages/ray-0.2.1-py2.7-linux-x86_64.egg/ray/plasma/../core/src/plasma/plasma_manager[0x408a56]
/home/travis/.local/lib/python2.7/site-packages/ray-0.2.1-py2.7-linux-x86_64.egg/ray/plasma/../core/src/plasma/plasma_manager[0x403a02]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)[0x7f1712ffdf45]
/home/travis/.local/lib/python2.7/site-packages/ray-0.2.1-py2.7-linux-x86_64.egg/ray/plasma/../core/src/plasma/plasma_manager[0x403fe7]
[FATAL] (/home/travis/build/ray-project/ray/src/local_scheduler/local_scheduler.cc:1218: errno: Operation now in progress) Check failure: current_time >= state->previous_heartbeat_time 

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/2078/
Test PASSed.

@robertnishihara robertnishihara merged commit 1e0ab3d into ray-project:master Oct 11, 2017
@robertnishihara robertnishihara deleted the monotonic-clock branch October 11, 2017 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants