Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Only install dataclasses on Python 3.6 #10936

Merged
merged 2 commits into from
Sep 22, 2020
Merged

[Serve] Only install dataclasses on Python 3.6 #10936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b7cc70
only install dataclasses on python 3.6
architkulkarni Sep 21, 2020
1194387
lint
architkulkarni Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/asan_tests/ray-project/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ aiohttp
blist
boto3
cython==0.29.0
dataclasses
dataclasses; python_version < '3.7'
dm-tree
feather-format
flask
Expand Down
4 changes: 2 additions & 2 deletions python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ tabulate
tensorboardX
uvicorn
pydantic
dataclasses
dataclasses; python_version < '3.7'

# Requirements for running tests
blist; platform_system != "Windows"
boto3
cython==0.29.0
dataclasses
dataclasses; python_version < '3.7'
dask[complete]
feather-format
gym
Expand Down
10 changes: 8 additions & 2 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,14 @@
# in this directory
extras = {
"debug": [],
"serve": ["uvicorn", "flask", "requests", "pydantic", "dataclasses"],
"tune": ["tabulate", "tensorboardX", "pandas", "dataclasses"]
"serve": [
"uvicorn", "flask", "requests", "pydantic",
"dataclasses; python_version < '3.7'"
],
"tune": [
"tabulate", "tensorboardX", "pandas",
"dataclasses; python_version < '3.7'"
]
}

extras["rllib"] = extras["tune"] + [
Expand Down