Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Polish community integrations docs #10780

Merged
merged 7 commits into from
Sep 14, 2020
Merged

[docs] Polish community integrations docs #10780

merged 7 commits into from
Sep 14, 2020

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Sep 14, 2020 •
edited
Loading

This should fix some of the small issues / inconsistencies left over from the previous PR, and also adds icons.

@richardliaw
Copy link
Contributor

Looks really good! Lint failing though. You'll need to fix this:

checking consistency... /Users/rliaw/ray/doc/source/dask-on-ray.rst: WARNING: document isn't included in any toctree
/Users/rliaw/ray/doc/source/mars-on-ray.rst: WARNING: document isn't included in any toctree
/Users/rliaw/ray/doc/source/pandas_on_ray.rst: WARNING: document isn't included in any toctree

richardliaw
richardliaw approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when lint tests pass w/o warning+error. consider explicitly cancelling the other builds (python/rllib builds are getting triggered).

@ericl
Copy link
Contributor Author

ericl commented Sep 14, 2020

Fixed.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 14, 2020
@ericl ericl merged commit daabe6b into ray-project:master Sep 14, 2020
barakmich pushed a commit that referenced this pull request Sep 23, 2020
@ericl @barakmich
[docs] Polish community integrations docs (#10780)
ca2365a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericl @richardliaw