Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Fix java doc building error #10757

Merged
merged 14 commits into from
Sep 14, 2020
Merged

Conversation

chaokunyang
Copy link
Member

@chaokunyang chaokunyang commented Sep 12, 2020

Why are these changes needed?

When build java doc with jdk11, we got the code being documented uses modules error. This PR fix it by using jdk8 and upgrade java doc plugin version.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@chaokunyang chaokunyang changed the title [Java] Fix java doc [Java] Fix java doc building error Sep 12, 2020
@raulchen
Copy link
Contributor

have you figured out the correct way to set jdk8?

@chaokunyang
Copy link
Member Author

Configurign jdk8 in linux is easy, using language: java and jdk: openjdk8. But it doesn't work on macos.

@chaokunyang
Copy link
Member Author

Install jdk8 on macosx manually

@raulchen raulchen merged commit 1aad8aa into ray-project:master Sep 14, 2020
@raulchen raulchen deleted the fix_java_doc branch September 14, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants